refactor: simplify upload code system API and remove user_id fields #74
+78
−239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major refactoring of the upload code system API to simplify the interface and improve consistency. The upload request structure has been consolidated and user ID references have been removed from multiple templates to support a more streamlined architecture. Key changes: - Unified upload request structure with simplified parameter handling - Removed user_id fields from chat, workflow, FHIR provider, and other templates - Updated upload code system to return asynchronous processing status - Consolidated upload request types into a single interface - Improved documentation for asynchronous processing workflow 🌿 Generated with Fern
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| export type { GetConstrueCodesCodesystemSearchTextRequest } from "./GetConstrueCodesCodesystemSearchTextRequest.js"; | ||
| export type { GetConstrueCodesSystemsCodesystemExportRequest } from "./GetConstrueCodesSystemsCodesystemExportRequest.js"; | ||
| export type { GetConstrueCodesSystemsCodesystemRequest } from "./GetConstrueCodesSystemsCodesystemRequest.js"; | ||
| export type { UploadRequest } from "./UploadRequest.js"; |
There was a problem hiding this comment.
Type-only export makes Format enum values inaccessible
Medium Severity
The UploadRequest namespace defines runtime const Format values (Csv, Json), but requests/index.ts re-exports it using export type { UploadRequest }, which strips the runtime value. SDK consumers cannot access UploadRequest.Format.Csv or UploadRequest.Format.Json at runtime — these are effectively dead code. The comparable GetCodeSystemDetailResponse.Status const is properly exported via export * from the types index and works correctly.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring of the upload code system API to simplify the interface and improve consistency. The upload request structure has been consolidated and user ID references have been removed from multiple templates to support a more streamlined architecture.
Key changes:
🌿 Generated with Fern
Note
Medium Risk
This is a breaking, SDK-wide generated schema change (v6 major) that alters request/response types for code system upload and removes fields from many response models, which can break downstream consumers and tests.
Overview
SDK v6.0.0 updates the generated TypeScript client to simplify custom code system uploads and remove
user_idfields from several templates.construe.uploadCodeSystemnow documents/assumes asynchronous processing (immediate 202 + pollingGET /construe/codes/systems/{codesystem}for status), consolidates prior CSV/JSON discriminated request types into a singleconstrue.UploadRequest(withformatenum and optional CSV/JSON fields), and expands the upload response to includenameandversionalongsidestatus. Multiple resource templates (agent chat messages/sessions, workflows, FHIR provider, summary templates, MCP server/tool responses) and wire tests are updated to no longer expectuser_id.Written by Cursor Bugbot for commit be12509. This will update automatically on new commits. Configure here.